371859 - browser.startup.homepage_reset is unused and should be removed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

As far as I can tell, browser.startup.homepage_reset is not used and should be removed from browserconfig.properties. Tracking blame for this pref is hard given the aviary branch landing and poor record keeping (no patches, sometimes no bugs), though, so if anyone can remember how this was used in the past, that'd be useful for confirming that it's no longer needed.

Comment 1

[Mike Connor [:mconnor]]

iirc, this was used for the "reset Firefox homepage" bit in the installer, and no longer matters.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

An MXR search doesn't turn up any results for homepage_reset and a separate MXR search for "browser.startup" doesn't return any results with anything that looks related to a "homepage reset".

I'm marking this as resolved-fixed. Please reopen or reclassify if I overlooked something or made this change in error.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I did find a mention of homepage_reset in the Seamonkey codebase though.

http://mxr.mozilla.org/seamonkey/source/other-licenses/branding/firefox/locales/browserconfig.properties#3

although this bug is for Firefox. CC'ing the Seamonkey folks to see if they have a plan of removing this from their codebase.

Comment 4

[[e-mail]]

(In reply to Jared Wein from comment #3)
> I did find a mention of homepage_reset in the Seamonkey codebase though.
> 
> http://mxr.mozilla.org/seamonkey/source/other-licenses/branding/firefox/locales/browserconfig.properties#3
> 
> although this bug is for Firefox. CC'ing the Seamonkey folks to see if they
> have a plan of removing this from their codebase.

No, that's actually Firefox 3.0 code you're looking at there.