371874 - Cleanup layout reftest lists

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: Clean up the layout reftests

Attached is a patch which sorts all of the layout reftests by bug number and alphabetically when necessary.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So in many cases the order was semantic -- starting with easier tests and moving to harder tests.  I think the only ones that should be sorted are the bugs, and just by bug number (leaving the current order within bugs).  And at the same time we should probably create a reftest.list in the bugs/ subdirectory and include it in the one above.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Sort only bug reftests and move them to separate list

Like so?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 256738 [details] [diff] [review]
Sort only bug reftests and move them to separate list

Yep, looks good.  r+sr=dbaron.

Do you need someone to land this for you?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.  (I also added a comment at the top saying to keep it sorted by bug number.)

Thanks for the patch.

Comment 5

[Jeff Walden [:Waldo]]

For the record, the object/ tests were sorted by the ordering found at their original location on biesi's site, so not rearranging them was the right thing to do.  :-)  I dislike opaque numbers, tho, so I tried to give them meaningful names to aid in guessing what they do if any one were to fail in the future.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

and I did try to list simpler tests first, more complex tests later there.