372868 - Schema out-of-date error check forces Tb to quit, so you can't disable Ln

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Matthew (lilmatt) Willis]

Spin-off from bug 369819

Currently, the schema out-of-date error check will quit the running app, rather than allow you to possibly munge your data.

This is fine for Sunbird, but for Lightning it has the unhelpful side effect of preventing you from getting to the Add-ons Manager to disable the offending version of Lightning.

For Lightning, instead of forcing Tb to quit, we should just disable Ln.

Comment 1

[David Fraser]

Thanks for filing this.
If we disable the extension, then an upgrade and reenable should make it work after a restart. This seems like a good solution.
We should be able to use nsIExtensionManager.disableItem (see )http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/public/nsIExtensionManager.idl#241

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

I tested this patch only with Lightning. Maybe the error message for Lightning needs some adjustment.

Comment 3

[Daniel Boelzle [:dbo]]

Comment on attachment 264180 [details] [diff] [review]
Patch v1

>Index: calCalendarManager.js
>+ *   Martin Schr�der <[e-mail]>
better no umlauts: Schroeder?

>+                var errorBoxTitle;
>+                var errorBoxText;
>+                var buttonLabel;
better prefix buttonLabel with errorBox like the other variables.

>                 buttonFlags = promptSvc.BUTTON_POS_0 *
dto.

>Index: calendar.properties
>+tooNewSchemaErrorBoxTextLightning=The calendar data in your profile was updated by a newer version of %1$S, and continuing will probably cause the information to be lost or corrupted. %1$S will be disabled and %2$S now restarted.
I would favor "XXX will now be disabled and YYY restarted.".

r=dbo assuming you have properly tested the patch, because I've not ;)

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Patchv2

Updated nits from review comment. Carrying forward r+.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED