Closed
Bug 372886
Opened 17 years ago
Closed 17 years ago
test_bug351601.html does not throw, but does not test either
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ray, Assigned: ray)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.12 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
This is a very simple test case. The bug says that, at one time, if the build ID was not set, then reading the navigator.buildID ivar from JavaScript would cause a crash. So, this test verifies that this call cannot crash. But this test, being part of the automated harness, will run only in environments where the build ID is set. There are no plans, AFAIK, to regularly build an app that does not have a build ID and then run the test suite on it. So, this test should check. If the build ID is set and this call does not throw, it should call todo(). It calls ok() right now. It should only do that if there build ID is not set. To claim that the test passes when the build ID is set is a false positive result.
Comment 2•17 years ago
|
||
Did you forget to ask for review? I don't understand why you make this todo(), it looks like it just doesn't need to be tested in production builds.
I changed the todo() to an innocuous ok(). When the test is run on production builds, it definitely should pass.
Attachment #257556 -
Attachment is obsolete: true
Attachment #258811 -
Flags: review?
Comment 4•17 years ago
|
||
Set the r? to sayrer. And I think setting isOK to false in the catch block and using the ternary operator instead of the if would be slightly better.
Attachment #258811 -
Flags: review? → review?(sayrer)
Updated•17 years ago
|
Attachment #258811 -
Flags: review?(sayrer) → review+
Updated•17 years ago
|
Whiteboard: [needs checkin] → [checkin needed]
Updated•17 years ago
|
Assignee: nobody → ray
Flags: in-testsuite-
Comment 5•17 years ago
|
||
Checking in test_bug351601.html; /cvsroot/mozilla/testing/mochitest/tests/test_bug351601.html,v <-- test_bug351601.html new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Updated•16 years ago
|
Component: Testing → DOM
QA Contact: testing → general
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•