Closed
Bug 373196
Opened 17 years ago
Closed 6 years ago
text selection with the mouse not working
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: tomeu, Assigned: romaxa)
References
Details
Attachments
(2 files)
986 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
3.58 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.2) Gecko/20060601 Firefox/2.0.0.2 (Ubuntu-edgy) Build Identifier: Text in a webpage in gtkmozembed won't be selected by the mouse. Ctrl-A works. Easily reproducible in TestGtkEmbed. Reproducible: Always Steps to Reproduce: Try to select some text on a webpage with the mouse. Actual Results: Nothing happens. Expected Results: The text would be selected and then could be copied, dragged, etc.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #259826 -
Flags: review?
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 259826 [details] [diff] [review] BUGFIX Just fixed default value state
Attachment #259826 -
Flags: review? → review?(timeless)
Comment 3•17 years ago
|
||
(Just something I noticed while looking at the patch: from EmbedEventListener: static PRInt32 sLongPressTimer = 0 [...] #if 1 if (sLongPressTimer) g_source_remove(sLongPressTimer); #else [...] sLongPressTimer = g_timeout_add(mLongMPressDelay, sLongMPress, mOwner->mOwningWidget); First, g_timeout_add returns |guint|, NOT (signed) |int32|. Second, sLongPressTimer isn't restored to 0 after g_source_remove.)
Assignee | ||
Comment 4•17 years ago
|
||
Probably we need to create some macro... like: #define GLIB_SOURCE_REMOVE(source) \ PR_BEGIN_MACRO \ if (source) { \ g_source_remove(source); \ source = 0; \ } \ PR_END_MACRO And this stuff will be in branch very soon.
Comment on attachment 259826 [details] [diff] [review] BUGFIX assuming I'm understanding this code correctly, please rename return_val to handled.
Attachment #259826 -
Flags: review?(timeless) → review+
Comment 6•17 years ago
|
||
Updated patch trying to address comments from chpe and timeless. Also fixes the bug ;) Any ETA we could get this to tree?
Updated•17 years ago
|
Attachment #281782 -
Flags: review?(timeless)
Comment 8•17 years ago
|
||
the attachment 281782 [details] [diff] [review] fixes it for me.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 281782 [details] [diff] [review] mouse-text-selection-bug-373196.patch this patch is currently blocked by whatever patch that will reintroduce that code.
Attachment #281782 -
Flags: review?(timeless)
Updated•12 years ago
|
Product: Core → Core Graveyard
Comment 10•6 years ago
|
||
Embedding: GTK Widget isn't a thing, closing.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•