373207 - l10n: rename entity / properties that changed due to bug #373211 (search.all.label, cmd.find.label, places.title, etc)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

"Search in Bookmarks & History" text should be "Search in Bookmarks", as we aren't going to expose history here, for FX 2.0 UI parity, right?

from http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/places/places.properties#60

searchDefault=Search in Bookmarks & History

But, on a related note, history results are showing up.  I'll log a bug about that, if we don't have one already.

Comment 1

[(not reading, please use [e-mail] instead)]

trivial patch coming for Fx 2 parity

Comment 2

[(not reading, please use [e-mail] instead)]

joey has a fix for this one as well, see bug #373211

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of a place where we have "All Bookmarks and History" and we should have "All Bookmarks"

Comment 4

[(not reading, please use [e-mail] instead)]

fixed as part of bug #373211.

thanks joey!

Comment 5

[(not reading, please use [e-mail] instead)]

marek writes:

Stuff like this:

 <!ENTITY places.title
-  "Places">
+  "Bookmarks Manager">

and like this:

 <!ENTITY cmd.find.label 
-  "Find in Bookmarks &amp; History...">
+  "Find in Bookmarks...">

and like this:

 <!ENTITY search.all.label
-  "All Bookmarks and History">
+  "All Bookmarks">

are semantic changes that require changing the entity name as well.

he's right, I'll fix that.

Comment 6

[Asaf Romano (gone)]

No, not as long as places-bookmarks are NPOB.

Comment 7

[Axel Hecht [:Pike]]

As far as l10n is concerned, there is not NPOB.

That's why I keep suggesting to put l10n files that aren't ready for our localizers out of the locale/en-US directories.

Places of course it particularily evil, as it was already partially localized during it's pre-1.5 stages.

Comment 8

[Asaf Romano (gone)]

Axel, whenever we turn on places-bookmark UI again, localizers would have to review their entire strings set for places, not only strings we tweaked/changed recently.

If you would like to see the locale files for places moved out of locales/ until finalized, please file a bug. I can spare few cycles on it if it helps localizers.

Comment 9

[(not reading, please use [e-mail] instead)]

reopening this particular issue on these particular strings based on discussion in axel's l10n meeting today in #places.

Comment 10

[(not reading, please use [e-mail] instead)]

taking to address comment #5

Comment 11

[(not reading, please use [e-mail] instead)]

l10n impact, so beta 1, updating summary, over to nobody

Comment 12

[(not reading, please use [e-mail] instead)]

note to steve, who might be taking this:

take a look at the fix for bug #373211

I made some string changes to both .properties and .dtd
and unless it is a simple whitespace, typo, or punctuation change
we need to rename the entity / property name
otherwise, localizer won't know things have changed

so we need to figure out what I did (or joey did) and fix those entities / properties

Comment 13

[Steve Won (stevewon on irc)]

Attachment: Patch

Hey Seth. Sorry this took so long. I took it up on Tuesday, but didn't get to touch it until this morning.

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 271082 [details] [diff] [review]
Patch

r=sspitzer, thanks steve for this cleanup (which will help our localizers).

I'll land as soon as the tree opens.

Comment 15

[(not reading, please use [e-mail] instead)]

fixed.  Thanks again Steve for fixing this before beta 1.

Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.92; previous revision: 1.91
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul

new revision: 1.76; previous revision: 1.75
done
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--
places.dtd
new revision: 1.25; previous revision: 1.24
done
Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v
  <--  places.properties
new revision: 1.20; previous revision: 1.19
done

Comment 16

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071805 Minefield/3.0a7pre

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv