373346 - About and Credits dialog is very much too tall

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Thunderbird 2.0pre 20070308 build

The about and credits dialog is very much too high. This looks ridiculous in an about dialog and should be fixed before the release.

Comment 1

[Scott MacGregor]

This is the same height as the firefox about dialog. I believe it was changed as part of the license landing.

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Additional the credits dialog does nothing - no scrolling text.

Comment 3

[Scott MacGregor]

(In reply to comment #2)
> Additional the credits dialog does nothing - no scrolling text.
> 

hmm, that's working for me on windows.

Comment 4

[Phil Ringnalda (:philor)]

(In reply to comment #1)
> I believe it was changed
> as part of the license landing.

By some incompetent hack who was supposed to notice that Fx also has a bigger image in about than in credits, so it doesn't look so... spacious.

Comment 5

[Magnus Melin [:mkmelin]]

Scrolling working on linux. Doesn't look that high to me, but then I have a decent sized screen...

Comment 6

[Scott MacGregor]

I downloaded a german build and the scrolling doesn't work there on Windows.
How strange. No errors in the console either.

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: About dialog

Comment 8

[Alex Ihrig [:Thunderbird_Mail_DE]]

1) I've tried the about/credits dialog with en-US credits.dtd and en-US about.dtd in the german Thunderbird build (repacked de.jar with the mentioned files) without success. So it shouldn't be a l10n problem of these files.

2) The dutch nl Thunderbird build has the same problems.

Comment 9

[Alexander L. Slovesnik]

No scrolling on Russian build in Linux too.
Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.1.3pre) Gecko/20070308 Thunderbird/2.0pre ID:2007030803

Comment 10

[Phil Ringnalda (:philor)]

And just to maximize confusion, I downloaded a de branch build, *did* get scrolling (in a new profile), noticed that the image on the first screen *was* larger, unlike my trunk build, and then went back to my trunk build and now it's larger too.

Comment 11

[Marek Stępień [:marcoos, inactive]]

Attachment: Linux Screenshot (Polish)

This is how it looks for me. Scrolling works OK.
UA: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.3pre) Gecko/20070309 Thunderbird/2.0pre

The spacing problem is not that bad if you have a bigger font, like I do (by default Linux/Gnome usually has bigger default font size than Windows).

Comment 12

[Marek Stępień [:marcoos, inactive]]

Scrolling works OK here:
Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.3pre) Gecko/20070309 Thunderbird/2.0pre

Comment 13

[Marek Stępień [:marcoos, inactive]]

Oops, the previous comment shouldn't have been added, sorry for bugspam. :)

Comment 14

[Alexander L. Slovesnik]

(In reply to comment #9)
> No scrolling on Russian build in Linux too.
> Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.1.3pre) Gecko/20070308
> Thunderbird/2.0pre ID:2007030803
> 
Huh, just downloaded lastest tinderbox build and scrolling works again. Sorry for false alarm.

Comment 15

[Phil Ringnalda (:philor)]

Okay, lack of scrolling was almost certainly bug 373181, so if you saw it, make sure you have a build from (well) after 17:01 Mozilla Standard Time 2007-03-08.

Moving the text down to the bottom of About I'll look at tonight, but the number of "this, that and the other cut off when I have something or that thing" bugs Firefox has had makes me leery at this point. Maybe it'll turn out to be something clean and clearly safe, though.

Comment 16

[Scott MacGregor]

Nice detective work Phil. I was most worried about the scrolling issue as that could have been a show stopper. 

Comment 17

[Alex Ihrig [:Thunderbird_Mail_DE]]

Credits scrolling is working again in Thunderbird 2.0pre 20070309. Only the height should be fixed.

Comment 18

[Phil Ringnalda (:philor)]

Attachment: like so?

I'm running short of useful ideas: making the dialog smaller would only work if you remove some of the boilerplate at the end of credits.xhtml, since otherwise the license and contributor links go off the top, but I doubt that any of it is there just because it's so much fun to read; moving the text in the about page of the deck down to the bottom is as easy as changing the separator to a spacer, but as this screenshot shows, it's not a whole lot prettier, since you can't move the "Mozilla Thunderbird" part down, because it's actually in the image.

Comment 19

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #18)
> Created an attachment (id=258975) [details]
> like so?

Oh no... then we should better change nothing.

Comment 20

[Phil Ringnalda (:philor)]

Attachment: A little spacey, v.1

While this doesn't look like a top-notch designer carefully arranged it for pixel-perfection, it at least strikes me as an improvement.

For bonus points, I uncommented the preprocessed version number, and got rid of the hard-coded "3 alpha 1" - I didn't see quite why it was hard-coded, from the bug, but it's been worrying me since I first spotted it, being out of the usual batch of places where someone doing a release expects to change numbers.

Comment 21

[Phil Ringnalda (:philor)]

Attachment: Linux screenshot

Comment 22

[Phil Ringnalda (:philor)]

Attachment: Mac screenshot

Comment 23

[Scott MacGregor]

Comment on attachment 260560 [details] [diff] [review]
A little spacey, v.1

this looks great Phil. Thanks for cleaning up the hard coded alpha string too, I think it looks fine without it.

Comment 24

[Phil Ringnalda (:philor)]

mail/base/content/aboutDialog.xul: 1.21