374633 - Spellcheck doesn't work in pt-PT Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: pt-PT / Portuguese, defect)

Description

[dynamis (Tomoya ASAI)]

pt-PT locale have spellcheck dictionary but it doesn't work in Thunderbird.
# I think this is important feature and requesting blocking-thunderbird2.

You should add below line to pt-PT/mail/all-l10n.js like en-US did in bug 373787.
  pref("spellchecker.dictionary", "pt_PT");
                                   ~~~~~
Note: your dictionary filename is pt_PT.dic/pt_PT.aff and the value should be "pt_PT", not "pt-PT".

FYI: Firefox will automatically set the pref when we load a page including textbox and you don't have to add the pref to browser/firefox-l10n.js.

Comment 1

[dynamis (Tomoya ASAI)]

Attachment: add spellchecker.dictionary pref in all-l10n.js

This is the patch.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

Scott, I think this patch could be something we'd still want to take. Risk is low, and I can land it on the branch tomorrow morning my time, if you approve it.

Comment 3

[Scott MacGregor]

Comment on attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

I verified that the other locales besides this one and zh-TW that ship dictionaries are setting spellchecker.dictionary correctly.

Comment 4

[João Neves]

Scott, is that an approval?

Comment 5

[Scott MacGregor]

yup, if you can land it right now, that would be great, otherwise Axel is going to land it when he wakes up.

Comment 6

[João Neves]

OK. Done. Commited. Thank you all.

Comment 7

[Scott MacGregor]

adding the fixed1.8.1.4 keyword since this was checked into the branch. Thanks João.

Comment 8

[Scott MacGregor]

we didn't block on this but we did take the fix. flag cleanup.

Comment 9

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 (Thunderbird 2.0.0.4) with Mozilla/5.0 (Windows; U; Windows NT 5.0; pt-PT; rv:1.8.1.4) Gecko/20070604 Thunderbird/2.0.0.4 ID:2007060411 the spellcheck is now working as expected - adding verified keyword