374682 - Patrocles Needs the Platform SDK Installed on it

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Scott MacGregor]

I just noticed that the 1.5.0.x machines for Thunderbird and Firefox are both listed as WINNT 5.2. Builds from these machines are built with the following command line flag:

-DOSTYPE=\"WINNT5.2\"

The same is true for Thunderbird and Firefox on the trunk.

However Patrocles, the build machine for Thunderbird 1.8, is listed as WINNT5.0 so we use the following flag:

-DOSTYPE=\"WINNT5.0\"

I'm nervous about shipping thunderbird 2 builds that are built from a different version of windows that 1.5.0.x and the trunk. I suspect this might be the cause of issues like Bug #306599 but am still investigating that. I wonder if there are other issues lurking there that we don't know about.

Comment 1

[Scott MacGregor]

Note: I don't know that this is a blocker, I don't know what it means to pass in different values of DOSTYPE between different release branches. Maybe the bits come out the same regardless of the value. But I'd like confirmation that it's ok for that value to differ just to be safe.

Comment 2

[Scott MacGregor]

It also looks like Patrocles does not have the windows platform SDK installed
on it per the build guidelines for Mozilla 1.8:

http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites_on_the_1.7_and_1.8_Branches#Platform_SDK

Thanks to Gavin and Ted for pointing this out.

In addition to installing the right SDK (can we verify the SDK that Pacific is
using for Firefox branch nightlies?)
we need to make sure the SDK paths get appended before the VC6 paths:

rem --- Prepend SDK paths
rem --- Only required for MSVC6
set PATH=%MSSDK%\bin;%PATH%
set INCLUDE=%MSSDK%\include;%INCLUDE%
set LIB=%MSDDK%\lib;%LIB%

Comment 3

[Scott MacGregor]

adjusting the summary accordingly and minusing this. We aren't going to do this before the release but may do something afterwards.

Comment 4

[(not reading, please use [e-mail] instead)]

see also bug #379738

Comment 5

[Mark Banner (:standard8)]

Given where we are on branch, i.e. TB 2.0.0.14, do we really want to change this now or let it go?

If we want to change it, then probably need to move to the mozilla.org product and something like server operations for tinderbox or release engineering.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

It's hard to tell without trying it.  It would be interesting to know what versions the trunk is using, though.

Comment 7

[[e-mail] (:bhearsum)]

v6.0, afaik
(from here: http://wiki.mozilla.org/ReferencePlatforms/Win32#Install_Microsoft.C2.AE_Windows.C2.AE_Software_Development_Kit_Update_for_Windows_Vista)

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #7)
> v6.0, afaik
> (from here:
> http://wiki.mozilla.org/ReferencePlatforms/Win32#Install_Microsoft.C2.AE_Windows.C2.AE_Software_Development_Kit_Update_for_Windows_Vista)
> 

Well the tinderbox header on trunk shows WIN NT 5.1, but the SDKVER in the log shows 6.

I can't actually confirm what Patrocles has at the moment - it doesn't have such useful environment variables.

Comment 9

[Mark Banner (:standard8)]

2.x is no longer supported, we don't need this bug any more.