375464 - Add-ons that are not themes or extensions are not shown on some pages

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Inspired by bug 375374: Add-ons like dictionaries and search engines aren't shown in people's user info pages and also result in an "Add-on not found" message if you try to go directly to their add-on page.  From the other bug:

> But the direct link https://addons.mozilla.org/firefox/3646/ still ends up in
> the oh-so-undescriptive "Add-on not found!" message, and it does not show on my
> User Info page https://addons.mozilla.org/en-US/firefox/user/57636 .

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I think this is major.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I have no idea why I thought this was major.

Comment 3

[Dan Kenigsberg]

Maybe it was because you thought that once-active links that float around the internet should not just die one day? That changes should be backward-compatible?

Now, at least mozilla.org shows a little explanation page, but still it does not lead the interested user to the addon. I still don't get how to add a comment, or read the comments left for me. In my opinion, the site took a serious turn to the worse, and still hasn't recoverred.

Comment 4

[Jesper Kristensen]

Attachment: Make old links redirect to correct page

BTW, we should do something about error pages in AMO, they are very confusing.

Comment 5

[Wil Clouser [:clouserw]]

Attachment: redirect dict/search/plugin

Thanks for the patch - I think it's good, but I want to keep the restriction on the find(), on the off chance we get another add-on type in the future and this starts returning way too many rows or something.

Comment 6

[Wil Clouser [:clouserw]]

Also, I meant to ask - what error pages are you referring to, and what should be done?  The flash() ones, or the http 400 errors?

Comment 7

[Jesper Kristensen]

Your changes are OK to me. I am not sure I understand that about too many rows. A query with the primary key (id) as a condition will not be able to return multiple rows, right?

---

Some Not Found errors gives the default Not Found page.
Example: https://addons.mozilla.org/da/firefox/notfound

Some gives a flash message and redirects to the home page after a short while.
Example: https://addons.mozilla.org/da/firefox/addon/100000000

Some just redirect to the home page instantly.
Example: Found one yesterday, cannot remember where

Some pages are shown, that should not exist.
Example: https://addons.mozilla.org/da/thunderbird/browse/type:4

I don't think the flash() messages should be used for error pages. There should be a bit more information, and it should not automatically redirect to the front page. Displaying the normal 404 page instead of the flash() would be a fine solution, I think.

The remaining flash() pages should have the same layout as the rest of AMO.

But all this is probably another bug.

Comment 8

[Jesper Kristensen]

We have a patch. Shouldn't it be committed to SVN?

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> We have a patch. Shouldn't it be committed to SVN?
> 

Sorry, I missed your last comment.  I've asked someone in irc to review it before I commit it.

> The remaining flash() pages should have the same layout as the rest of AMO.
> But all this is probably another bug.

I agree they could use some help, and I also agree that it's a different bug.  I've mentioned it to Madhava to roll into his UI review.

Comment 10

[Justin Scott [:fligtar]]

Comment on attachment 267153 [details] [diff] [review]
redirect dict/search/plugin

r=fligtar

Comment 11

[Wil Clouser [:clouserw]]

Thanks Justin and Jesper - patch is in SVN, r4535.  Check out http://remora.stage.mozilla.com/ in a few minutes to see it.

Comment 12

[Jesper Kristensen]

I am not sure that marking this bug fixed is the right thing to do, since the patch only addresses a fraction of this bug. Please reconsider.

Comment 13

[Fred Wenzel [:wenzel]]

Which points are still open in particular?

Issues with error pages should probably become a new bug to not clutter this one.

Comment 14

[Jesper Kristensen]

> Add-ons like dictionaries and search engines aren't
> shown in people's user info pages
OPEN

> result in an "Add-on not found"
> message if you try to go directly to their add-on page.
FIXED

> I still don't get how to add a
> comment, or read the comments left for me.
OPEN