375662 - Fix a couple of ATSUI issues

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

1) SetupClusterBoundaries is totally broken. It needs to set kUCTextBreakLeadingEdgeMask for the calls to UCFindTextBreak and it needs to not just ignore the first break found. (This only affects new textframe.)

2) See
http://weblogs.mozillazine.org/roc/archives/2007/02/superlaser_targ.html#comments
The issues I saw with trailing whitespace are apparently "as intended". Instead of messing around with the output as I did, a slightly simpler workaround is to append a non-whitespace character, say ".", to the text when we wrap it in LRO/RLO + PDF. Then there is no trailing whitespace. It's easy to ignore that character's glyph in PostLayoutCallback.

While making this change I also changed the string length passed into InitTextRun and MakeTextRunInternal to include any wrapping characters. This is better than before, when I left it as the length of the original string, even though aString pointed to the wrapped string not the original string.

I reran font selection and other tests and things look good.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: real patch

The last patch omitted the .h changes.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.