Closed
Bug 375754
Opened 17 years ago
Closed 17 years ago
regression: submission replace instance with method=post broken
Categories
(Core Graveyard :: XForms, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aaronr, Assigned: aaronr)
References
Details
(Keywords: fixed1.8.0.12, fixed1.8.1.4)
Attachments
(1 file)
|
5.07 KB,
patch
|
smaug
:
review+
doronr
:
review+
|
Details | Diff | Splinter Review |
Looks like I regressed submission with my patch for bug 357901. There is a comment in the code that SetUploadStream will set the request header to have method 'put', but I completely missed that when I moved the post submission logic to execute sooner in the ::SendData method. I did that since we already had the httpChannel at that point. To fix this regression, I moved the code back to after the call to SetUploadStream and moved the httpChannel variable out in scope so that it can be used later, too, without having to do another QI.
Attachment #259953 -
Flags: review?(Olli.Pettay)
Attachment #259953 -
Flags: review?(doronr)
|
||
Updated•17 years ago
|
Attachment #259953 -
Flags: review?(Olli.Pettay) → review+
|
||
Updated•17 years ago
|
Attachment #259953 -
Flags: review?(doronr) → review+
checked into trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
checked into 1.8 branch on 2007-04-12 checked into 1.8.0 branch on 2007-04-16
Keywords: fixed1.8.0.12,
fixed1.8.1.4
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•