376129 - Missing-glyph hexbox digits should become larger at larger font sizes (and when zooming)

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load data:text/html,<big><big><big><big>A&#45131;

Result: the border of the the hexbox is large, but the digits are tiny.

Expected: the digits should be large enough to read comfortably.

Comment 2

[Biju]

Zoom issue test:-
* Zoom and watch following char ൰൱൲൳൴൵൶൷൸൹ഩ

Comment 3

[Bas Schouten (:bas.schouten)]

John, do you think we should make the digits bigger? And if so do you care to own this bug?

Comment 4

[Gregory Pappas [:gregp]]

Attachment: testcase.html

I think(?) this still reproduces, on Linux at least.

Comment 5

[Jonathan Kew [:jfkthame]]

This has periodically annoyed me, as the tiny digits can be quite hard to read (or my eyes are getting old!) When the font size is large, so there's lots of room in the tofu rectangle, we should make the digits correspondingly larger.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 376129 - Scale the missing-glyph hex digits more usefully for large font sizes. r=#gfx-reviewers

This makes the digits scale up to better fill the box, as it looks a bit odd to have
the box grow with the font size but the digits remain tiny in the middle of it.

One thing that may look a little odd with this version is that 6-digit hexboxes tend
to get smaller digits than 4-digit ones with large font sizes. But I think that's
OK; it allows the 4-digit chars to be more readable, and 6-digit (non-BMP) ones are
generally much rarer.

(And the whole thing is basically cosmetic anyhow; this isn't about rendering web
content as intended, but trying to provide a bit of useful information when the
content is somehow broken or not renderable.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36da3251f961
Scale the missing-glyph hex digits more usefully for large font sizes. r=gfx-reviewers,lsalzman

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/36da3251f961