37617 - sample plugin won't compile

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Axel Hecht]

When trying to compile the sample plugin in
modules/plugin/test
I get the following compile error:

/tmp/mozilla/modules/plugin/test/npsimple.cpp: In function `nsresult
NSRegisterSelf(class nsISupports *, const char *)':
/tmp/mozilla/modules/plugin/test/npsimple.cpp:522: no matching function for call
to `nsString::nsString (char[36])'
../../../dist/include/nsString2.h:89: candidates are: nsString::nsString()
../../../dist/include/nsString2.h:95:                 nsString::nsString(const
nsString &)
../../../dist/include/nsString2.h:107:                 nsString::nsString(const
PRUnichar *, PRInt32)
../../../dist/include/nsString2.h:130:                 nsString::nsString
(nsSubsumeStr &)
/tmp/mozilla/modules/plugin/test/npsimple.cpp:551: no match for `nsString & +=
char[21]'
../../../dist/include/nsString2.h:521: candidates are: nsString::operator +=
(PRUnichar)
../../../dist/include/nsString2.h:525:                 nsString::operator +=
(const nsString &)
../../../dist/include/nsString2.h:526:                 nsString::operator +=
(const PRUnichar *)
make: *** [npsimple.o] Error 1


Axel

Comment 1

[Nick Mathios]

Emailed the reporter about the date of file npsimple.cpp as it seems to 
reference nsString2.h which is not in the latest copy of the code.  Similar to 
bug 31114.

Comment 2

[Axel Hecht]

nsString2.h is included from nsString.h, so it's still there.
The cvs version is from today, May 2nd.
It looks like this bug is a dup of bug 31114. That is worksforme, and should be 
reopended. If this bug is marked dup, please put the uptodate info on 31114.

I looked abit on the error mesgs, and the problem is, that npsimple uses some
defines for strings, which are char[]. And nsString can't handle those.
The defines are on lines 141-144.

Axel

Comment 3

[Braden]

Axel: I notice that bug 31114 is against Linux, while this one is against
Solaris. If it is working for them and not for you, then it is probably not a
duplicate of this one.

Can you confirm whether you are still having the problem documented in this report?

Comment 4

[Axel Hecht]

Checked, works now, is even displaying the content.

Haven't tried for quite a while, sorry.

Axel

Comment 5

[shrirang khanzode]

marking verified based on Axel's comment.