Closed
Bug 376355
Opened 17 years ago
Closed 16 years ago
Redundant STYLE_STACK_DEPTH, STYLE_CURRENT_STACK macros
Categories
(Core :: Graphics: Canvas2D, defect, P1)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: philip, Assigned: joe)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
vlad
:
review+
vlad
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070402 Minefield/3.0a4pre Build Identifier: nsCanvasRenderingContext2D.cpp defines STYLE_STACK_DEPTH and STYLE_CURRENT_STACK, but they are never actually used anywhere (and they cause minor confusion because they make it look like the stack has a limited size when actually it doesn't). They are used in the 1.8.0 branch, but were made redundant by bug 333177 and are not used in 1.8 or trunk. Reproducible: Always
|
||
Updated•17 years ago
|
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
Priority: -- → P1
Attachment #307374 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: helpwanted → checkin-needed
|
||
Comment 3•16 years ago
|
||
Comment on attachment 307374 [details] [diff] [review] easy patch Please re-add the checkin-needed keyword once you have approval.
Attachment #307374 -
Flags: approval1.9?
Attachment #307374 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•16 years ago
|
||
Checking in content/canvas/src/nsCanvasRenderingContext2D.cpp; /cvsroot/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp,v <-- nsCanvasRenderingContext2D.cpp new revision: 1.123; previous revision: 1.122 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
You need to log in
before you can comment on or make changes to this bug.
Description
•