376496 - Formatting is bogus when start and end time don't belong to the same timezone

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Daniel Boelzle [:dbo]]

The print formatter code assumes that all passed in events with all its start and end times relate to the same timezone which need not be the case. E.g. regarding WCAP, endDate are sometimes returned in UTC by the server while the startDate has a specific timezone set.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: forcing default timezone for print formatting

proposal patch:
- making sure that the print formatters stick to the default timezone
- making sure that the date formatter uses the same timezone for start/end for intervals

BTW: The late-init code in calUtils.js: calendarDefaultTimezone won't reflect changes to the pref, so I think we should install a pref listener for gDefaultTimezone.

Comment 2

[Daniel Boelzle [:dbo]]

Attachment: minor opt for getInTimezone

Since getInTimezone is called lots of times and the timezone is most often the same, those calls are most often only cloning the datetime object. Thus I am proposing this little optimization.

Comment 3

[Matthew (lilmatt) Willis]

Comment on attachment 260865 [details] [diff] [review]
minor opt for getInTimezone

This looks okay to me, but I'd rather have mvl or ctalbert take a look.  They're more familiar with this file.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 260595 [details] [diff] [review]
forcing default timezone for print formatting

r=lilmatt

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 260865 [details] [diff] [review]
minor opt for getInTimezone

r=mvl

Comment 6

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 7

[Andreas Treumann]

Verified in thunderbird build 2007071103, task is fixed.