376948 - Useless margin-top rules in quirk.css for form?

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

See url, since form is already set to to margin-top: 0 at:
http://lxr.mozilla.org/seamonkey/source/layout/style/quirk.css#288
the form selector part there seems rather useless. So I think those can be removed.

IE seems to have margin-top: 1em for forms, so maybe we want to follow that instead.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase1, form that is no first or last node

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase2, form is first-node

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase3, form is last-node

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase4, form is first-node in td

Comment 5

[Martijn Wargers (dead)]

Attachment: testcase5, form is last-node in td

Comment 6

[Martijn Wargers (dead)]

Results for IE:
             margin-top?  margin-bottom?
testcase1 -  yes          yes
testcase2 -  no           yes
testcase3 -  yes          -
testcase4 -  no           yes
testcase5 -  yes          yes

Comment 7

[Martijn Wargers (dead)]

Attachment: 261057: testcase1a, empty form that is no first or last node

Comment 8

[Martijn Wargers (dead)]

Attachment: testcase2a, empty form is first-node

Comment 9

[Martijn Wargers (dead)]

Attachment: testcase3a, empty form is last-node

Comment 10

[Martijn Wargers (dead)]

Attachment: testcase4a, empty form is first-node in td

Comment 11

[Martijn Wargers (dead)]

Attachment: testcase5a, empty form is last-node in td

Comment 12

[Martijn Wargers (dead)]

Same result in IE7 for these testcases.

Comment 13

[Martijn Wargers (dead)]

Attachment: patch

This patch makes Mozilla behave differently in these cases:
-testcase2a, empty form is first-node
-testcase4a, empty form is first-node in td
But that makes Mozilla actually more compatible with IE.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 261080 [details] [diff] [review]
patch

r+sr=dbaron.  Sorry for taking so long to get to this.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 261080 [details] [diff] [review]
patch

a1.9=dbaron

Comment 16

[Martijn Wargers (dead)]

Checking in quirk.css;
/cvsroot/mozilla/layout/style/quirk.css,v  <--  quirk.css
new revision: 1.57; previous revision: 1.56
done

Checked into trunk.