Closed Bug 377110 Opened 17 years ago Closed 17 years ago

Strip out some un-needed rules from Camino-only forms.css

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: jaas)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch cleanup (obsolete) — Splinter Review
I went through the rules in the Camino-only section of forms.css and pulled out a few that no longer appear to be necessary given the current state of trunk. This should make it a bit easier to see what's left to implement in the theme code so we can eventually rip the rest out without causing regressions.
Attachment #261216 - Flags: review?(joshmoz)
Comment on attachment 261216 [details] [diff] [review]
cleanup

Fine with me if it doesn't make camino unusable - the smaller the CSS diff between camino and Firefox the better.
Attachment #261216 - Flags: review?(joshmoz) → review+
While you are at it, you could also remove the background-color rule from
input,
input[disabled] {
  padding: 0px 1px 0px 1px;
  font-size: 11px;
  margin: 1px 1px 1px 1px;
  background-color: -moz-field;
}

That one line causes disabled textfields to paint as gfx, for which I just filed bug 377124.
Attached patch v2Splinter Review
Yep, thanks. I thought I tried that and ended up with transparent fields, but apparently not since it works for me now.
Attachment #261216 - Attachment is obsolete: true
Attachment #261258 - Flags: review?(joshmoz)
Attachment #261258 - Flags: review?(joshmoz) → review+
Attachment #261258 - Flags: superreview?(dbaron)
Attachment #261258 - Flags: superreview?(dbaron) → superreview+
Landed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Blocks: 377124
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: