Closed Bug 377456 (land-sr) Opened 17 years ago Closed 16 years ago

Land Serbian Firefox localization on trunk

Categories

(Mozilla Localizations :: sr / Serbian, defect)

Product:
Mozilla Localizations
Component:
sr / Serbian
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

This bug tracks the landing of the Serbian Firefox localization on trunk.

Filip, please land the work that corresponds to en-US on the MOZILLA_1_8_BRANCH on the trunk. If you need help with that, I'll be happy to assist.

We'll try to get the work as close to ship on the trunk as possible before actually branching, that'll make life easier for everyone.
Some help would be nice.  I checked out the l10n module from mozilla cvs.  If I am correct, I should first select the MOZILLA_1_8_BRANCH, add a dir sr/ and add all the respective files to it. 

Am I correct to suppose that this is  enough for 'sr'-localized builds to appear.   What about language packs?

thanks,f

I just committed to MOZILLA_1_8_BRANCH.  Can you please check that all is well?

10x,f

I said trunk and I meant trunk. The MOZILLA_1_8_BRANCH is frozen, no check-ins on that branch should happen without explicit approval on explicit changes, that means, patches need to be attached to bugs and request approval1.8.1.4 (that will be bumped to .5 soon) by setting that flag to '?', then wait for approval (which will be done by setting the flag to '+', if it is approved), and then check-in.

Please land on the trunk again, and we'll need to figure out what to do with the branch files after that.
Oops.

What I read was:
"Filip, please land the work that corresponds to en-US on the MOZILLA_1_8_BRANCH", and that is what I did.  The "...on the trunk" part didn't parse in my head.  Sorry.

Can you then please confirm that you want me to commit to HEAD?  Or if not, please be kind to specify which tag I should get to be correct.  

Please bear in mind that I am fairly new in this game (Mozilla l10n, not cvs), so what seems obvious to you (e.g. trunk == HEAD) may not be obvious for me (trunk == ?). 

Yep, please commit to HEAD. "trunk" is just a common other word for that, used across many projects, you'll find it in most svn repos, too, for example.

So here's a little more verbose wording on this:

You'd be working on a localization of the MOZILLA_1_8_BRANCH, that is, whatever you're doing right now should be comparing and working again en-US strings on that branch.

We'll be landing that work on the trunk (HEAD) of l10n/sr, so that we can do quicker fixes and turnarounds, and once we have a good feeling about that source producing a localization, we'd branch it, to MOZILLA_1_8_BRANCH. That will get the Serbian localization into a more formal release process. Does that make sense? And yes, we worked on documenting this process a bit on Friday, but there's nothing public on it yet.
There are some fixes to be done, please see the sr section at the end of http://people.mozilla.com/~axel/l10n/incubatorlog.txt. Not too much for now. Please make sure to remove the google reference in the migration wizard, check back on the current state of the en-US string for that.

In browser/profile/bookmarks.html, please change the 'en-US' strings (two in each url) to 'sr', and translate the titles?

In browser/searchplugins, please cvs remove the .xml files, you only need list.txt for the plugins that are in en-US, too. Changes to that list should be handled in the productization bug, I'll file that shortly.
I added the serbian localization of Firefox to http://l10n.mozilla.org/buildbot/, too, so now builds of language packs against fx 2.0.0.4 kick off automatically.

I manually triggered a build, that's looking pretty good already, http://l10n.mozilla.org/buildbot/linux-incubator/builds/17/step-moz%3Acomparelocales/0 is the log. There's one file in extensions/reporter missing, chrome/reporterOverlay.properties, and some obsolete entries in other-licenses/branding/firefox/brand.properties, which can be removed.
All complaints from 
http://l10n.mozilla.org/buildbot/linux-incubator/builds/17/step-moz%3Acomparelocales/0

were handled.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
There are more issues here, reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Should be fine now.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
We shouldn't close this bug until we have successfully branched, for which
we'll need at least the productization bug to be fixed. Which reminds me that I
need to file that one, gonna do that in a minute.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 384457
Filmil, I have seen that you landed a dictionary for Serbian. 

What's the licensing of that? It needs to be compatible with all three licenses, MPL, GPL, LGPL. See http://wiki.mozilla.org/L10n:Dictionaries, too.
No longer depends on: 384457
The dictionary was put together by one Igor Miletic (no relation to me).  I have his written permission to include the dictionary.

Should I ask him to put an explicit license on the dictionary?
(In reply to comment #13)
> Should I ask him to put an explicit license on the dictionary?

Yes, please. It should either be triple license or BSD, IIRC.
Hm, no favorable reply so far.  Either take an obsolete version, or re-negotiate licensing.  I removed the dictionaries from CVS until this is resolved.
Assignee: nobody → filmil
Status: REOPENED → NEW
BTW, where should I deposit these licenses, once I obtain them?
OK, I got the license.  The spelling checker is back to the CVS, along with the file LICENSE.txt that details the license.
Cool, please update http://wiki.mozilla.org/L10n:Dictionaries with your information, too? Thanks
Blocks: fx20-sr
Depends on: 394746
Depends on: 384457
No longer depends on: 394746
Can this be closed now?
Status: NEW → ASSIGNED
No. Bug 384457 is still open, and will need more work, I'll comment over there.

What amount of testing did you get on the existing language packs? Which platforms have been tested?
I can test only IA32 with Linux, on F7.  I have no resources to try other platforms, and was hoping to get the builds from Mozilla.  Can this be arranged?

I did not test the translation.  But in principle, the translation text was used for the Thunderbird and Firefox language packs.  I tested these on IA32 Linux, and IA32 Windows XP.

Nevertheless, I would like to see localized FF and TB too.
Here is the list of incosistences I have found (I think it is easier to file them here than to make for each one a bug):

1. Page - "Strana" in most cases e.g. Save page as, but "Stranica" in "Page setup"
2. Sidebar - "Bočni panel" in View menu, but "traka postrance" in history. The second translation is wrong, though one can think of "Bočna traka" (later on why).
3. Cut - "Ubaci" in Edit menu, but in context menu on search bar "Nalepi". I prefer the first translation
4. Bookmark - "Omiljeno" as main menu item, but "Beleška" in Tools/Options. I think that "Beleška" is much more in the spirit of Firefox/Mozilla as avoiding "Favorites" is preferred.
5. Downloads - "Preuzimanja" in Tools menu, but "Prijemi" in Tools/Options. First one is better.
6. Enable - "Omogući" almost everywhere, but "Uključi" at Tools/Options/Enable Java
7. web site - "veb mesto" everywhere except "el. mesto" in Tools/Options and Help and "sajt" in History sidebar/View, first one sounds OK
8. Upgrade - "Unapređenje" and "dogradnja", but both are not real thing... "Aktuelizacija" is the best I can think of, I'll try to check Microsoft and Ubuntu translation
9. Cancel - "Otkaži" everywhere, but "odustani" in Download manager

Ivan, I'd prefer that these things be separate from the landing of the trunk.  This way, when I'm finished I can close it and know I'm done.  

I'll* open a new bug about this and will add you to CC.

* Subject to approval of higher powers :)

OK, I have around 10 comments which are not inconsistency related (though you can say that something is incosistent with language or other translations if it is not translated as it is expected :) ). I can open 10 bugs, but it is a bit of bother. Is it custom to open single bug in such cases, I guess all other localization had similar problems (though they had more people to work on them, which possibly made things easier)?
I don't know how others did this.  I have nothing against opening a bug for a batch of remarks, or just reusing BUG 400867.  (See if anyone else has remarks)
OK to close?
Trunk has landed, seems OK to close.  Axel?
Assignee: filmil → nobody
Status: ASSIGNED → NEW
Yes, closed.
Status: NEW → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.