377579 - Color stays in view when deselecting 'use color' in sunbird.

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.4pre) Gecko/20070415 Calendar/0.5pre

Steps:
* Set a color for a category
* Create an event with this category.
* Remove the color from the category.

Result:
* The colored border stays, even if the view is refreshed.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix getPrefSafe

I have tracked down the Problem.

* getPrefSafe throws NS_ERROR_UNEXPECTED in [1], the rule is never deleted.
* nsIPrefBranch::clearUserPref() [2] says it will delete the preference if there is no default value, but it doesn't until you restart the application. The preference stays with a null default value, which throws the above NS_ERROR.
* The issue is fixed on trunk in bug 193332. This means we need to work around it.
* The attached patch should function as a workaround.

[1] http://mxr.mozilla.org/mozilla1.8/source/calendar/base/content/calendar-views.js#316
[2] http://mxr.mozilla.org/mozilla1.8/source/modules/libpref/public/nsIPrefBranch.idl#209

Comment 2

[Joey Minta]

Comment on attachment 261664 [details] [diff] [review]
Fix getPrefSafe

See also bug 340229.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This bug is rather visible and the patch is quite harmless. Therefore, I'm requesting blocking.

Comment 4

[Stefan Sitter [:ssitter]]

The fix in this patch is the same as in Bug 372626.

Comment 5

[Simon Paquet [:sipaq]]

This can be checked in, as per the conference call.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on MOZILLA_1_8_BRANCH and HEAD.

-> FIXED

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

verified on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.4pre) Gecko/20070426 Calendar/0.5pre

Comment 9

[Damian Szczepanik]

Litmus testcase 2625 created