377674 - wizard.xml cleanup

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Neil Deakin]

Attachment: setters should return values, mark some properties readonly

Comment 1

[Asaf Romano (gone)]

Comment on attachment 261714 [details] [diff] [review]
setters should return values, mark some properties readonly

>Index: toolkit/content/widgets/wizard.xml
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/content/widgets/wizard.xml,v
>retrieving revision 1.32
>diff -u -p -8 -r1.32 wizard.xml
>--- toolkit/content/widgets/wizard.xml	9 Sep 2006 08:18:59 -0000	1.32
>+++ toolkit/content/widgets/wizard.xml	16 Apr 2007 20:29:23 -0000
>@@ -30,21 +30,21 @@
>       <xul:hbox class="wizard-buttons" anonid="Buttons" xbl:inherits="pagestep,firstpage,lastpage"/>
>     </content>
>     
>     <implementation>
>       <property name="title" onget="return document.title;"
>                              onset="return document.title = val;"/>
> 
>       <property name="canAdvance" onget="return this._canAdvance;"
>-                                  onset="this._canAdvance=val; this._nextButton.disabled = !val;"/>
>+                                  onset="this._canAdvance=val; this._nextButton.disabled = !val; return val;"/>

hrm, maybe make that: this._nextButton.disabled = !val; return this._canAdvance = val;?
>       <property name="canRewind" onget="return this._canRewind;"
>-                                 onset="this._canRewind=val; this._backButton.disabled = !val;"/>
>+                                 onset="this._canRewind=val; this._backButton.disabled = !val; return val;"/>
> 

ditto.

r=mano.

Comment 2

[Neil Deakin]

Test is part of bug 377253, but need a better test that tests the <wizard> api in general.