377971 - some passing tests have the word "failed" in them in results.html

Status: RESOLVED FIXED

(NSS :: Test, defect, P2)

Description

[Julien Pierre]

Attachment: Change test strings for passing cases

The following lines show up in results.html where all tests pass :

Certutil failed in a nonexisting dir 255 	Passed
Dbtest readonly failed in a nonexisting dir 46 	Passed
Tstclnt failed in an empty dir 1 	Passed
Dbtest readonly failed in an empty dir 46 	Passed
Certutil failed in an empty dir 255 	Passed
Dbtest r/w failed in an readonly dir 46 	Passed
Certutil failed in an readonly dir 255 	Passed

I think it's confusing to have the word "failed" show up there, since that's the same word present in the "Result" column when a test fails. I know the case is different, but I have been finding this confusing for years. So, I propose to change it from "failed" to "didn't work" in the test name for those 7 cases.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 262055 [details] [diff] [review]
Change test strings for passing cases

r=nelson for trunk.
I'm concerned about the use of the apostrophe in the strings, but if they break anything, that will be easy to fix.

Comment 2

[Julien Pierre]

Thanks for the quick review, Nelson !

I fixed this on the trunk.

Checking in dbtests.sh;
/cvsroot/mozilla/security/nss/tests/dbtests/dbtests.sh,v  <--  dbtests.sh
new revision: 1.13; previous revision: 1.12
done

Comment 3

[Julien Pierre]

Nelson,

We already have many apostrophes in test names in results.html, so I think we will be OK. Also, I ran all.sh with my patch before submitting it and there were no issues.