378389 - Consider keeping track of preserved wrappers as an nsINode bit

Status: RESOLVED DUPLICATE of bug 457022

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

If we make AddReference/RemoveReference take an nsINode*, not a void* as the key, we could set a bit on the node when the reference is added and remove it when it's removed.

Then during cycle collection we could check that bit before hitting the hashtable.  Since most nodes don't have a preserved wrapper, this ought to be a win, I think.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that with sicking's patch to short-circuit traversal of currently-displayed documents this may not be as much of a problem anymore...

Comment 2

[Peter Van der Beken [:peterv]]

I'm going to dupe this to bug 457022 (cached wrappers), since we only traverse to the cached wrapper if a bit is set (see WRAPPER_BIT_PRESERVED) and we only put the objects in a hash if they have a preserved wrapper.