378762 - Add echo-variable-% for client.mk vars

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Axel Hecht [:Pike]]

Attachment: morph echo_ backdoor to work for all vars

I'd like to open the existing backdoor in client.mk to actually get any client.mk variable out of it. That would enable me to actually use the variable definitions for modules and locales and all that from outside make, i.e. python and buildbot.

The existing backdoor echo_objdir was added for camino (bug 201860), but isn't used anymore, so I'd like to tweak it to actually work for echo_%.

Comment 1

[Benjamin Smedberg]

Comment on attachment 262782 [details] [diff] [review]
morph echo_ backdoor to work for all vars

as discussed on IRC, I'd like this to be echo-variable-%

Comment 2

[Axel Hecht [:Pike]]

Attachment: patch landed on trunk

This is the patch that I landed on the trunk, attaching here for branch landing, too.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 263022 [details] [diff] [review]
patch landed on trunk

Per discussion on irc with dveditz, this is good for the branch. Requesting approval1.8.1.4.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 263022 [details] [diff] [review]
patch landed on trunk

approving for landing for 1.8.1.4, as per discussion with dveditz on irc.

Comment 5

[Axel Hecht [:Pike]]

FIXED on both trunk and MOZILLA_1_8_BRANCH

Comment 6

[cmtalbert]

verified that the code did land on branch and trunk, marking verified.