378782 - Thunderbird installation instructions are incorrect if EULA present

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Justin Scott [:fligtar]]

The Thunderbird installation instructions are incorrect if the add-on has a EULA, as right clicking on the file will only save the EULA page. The instructions should probably not appear on these pages and instead appear on the EULA page.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: Only show instructions on EULA page.

Bug 401272 changed the button labels and fixed the mime types for downloading tb attachments.  This removes the instructions from the page if there is a EULA.

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 296891 [details] [diff] [review]
Only show instructions on EULA page.

Hm. I don't think it works like this: This patch won't show the instructions at all if there's a EULA present, not even on the policy page.

I believe while we should not show the box on the page when the button links to the policy page, we should still display the box on the policy page itself.

Is there a variable we can check ($this->action or so?) in order to find out if we are currently on the policy page or not?

Comment 3

[Fred Wenzel [:wenzel]]

Comment on attachment 296891 [details] [diff] [review]
Only show instructions on EULA page.

Oh, in fact, as you pointed out, your patch *does* behave the way I described.

In that case, r+ing. This is good to go. :)

Comment 4

[Wil Clouser [:clouserw]]

thanks, r9605