Closed Bug 378886 Opened 17 years ago Closed 17 years ago

Forward imap messages as attachments misses start of forwarded message body

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file)

proposed fix
4.16 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review 
Forwarding imap messages as attachments doesn't include forwarded message's body - this is a regression from the filespec removal, I'm pretty sure.

Forwarding local messages seems to be fine.
Actually, this affects local messages as well - the actual bug is that the first couple hundred bytes of the message body seems to be getting skipped...very strange.
Status: NEW → ASSIGNED
Summary: Forward imap messages as attachments doesn't include forwarded message body → Forward imap messages as attachments misses start of forwarded message body
The bug is here:

http://lxr.mozilla.org/mozilla/source/mailnews/compose/src/nsMsgSendPart.cpp#729

ReadLine reads ahead into a buffer, which throws off the file pointer. So we need to either seek back to where the previous line ended, or somehow figure out how to get the data out of the line buffer. Or, most likely, just stop using the lineinput stream, and use NS_ReadLine directly.
Attached patch proposed fix — — Splinter Review 
use NS_ReadLine, which lets us know how far off the underlying stream pointer is...
Attachment #262917 - Flags: superreview?(mscott)
Attachment #262917 - Flags: superreview?(mscott) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: