379303 - Make dashed/dotted border rendering pretty again

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

As part of the landing of bug 368247 dashed and dotted borders aren't as pretty as they used to be, especially at thick border widths in a small space.  This should be fixed; it should not be an especially complicated fix, just some extra logic in creating the paths.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: example showing old and post-patch dashed rendering

example.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The stuff in bug 19963 should be considered when fixing this, if possible.

Comment 3

[Dan POPA]

Attachment: bg image used in the next attachment

Comment 4

[Dan POPA]

Attachment: In FF3 the top border of an element is rendered with a smaller height if the DIV is empty and border-top-style is not (dotted or dashed) and border-bottom-style is (dotted or dashed) and border-top-width is greater than border-bottom-width

In FF3 the top border of an element is rendered with a smaller height if:

* the DIV is empty and
* border-top-style is not (dotted or dashed) and 
border-bottom-style is (dotted or dashed) and * border-top-width is greater than border-bottom-width

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The previous comment was filed as bug 417246, which should block.

I think this one shouldn't block, although I'll leave it wanted.

Comment 6

[Vital]

This is essentially the same bug as https://bugzilla.mozilla.org/show_bug.cgi?id=19963.
That bug has the highest priority of all dotted-border-corners-ugly related bugs. It is also the oldest and it has a (seemingly active) developer assigned to it.
I suggest to "merge" this bug with 19963. If you care, please check it out and vote for it.

Comment 7

[Boris Zbarsky [:bzbarsky]]

It's not quite the same bug.  Fixing that bug might fix this one, but this one can be fixed without fixing the other, really, since this one is a recent regression and the other clearly is not.

Comment 8

[Zack Weinberg (:zwol)]

IMO it doesn't make sense to do anything but fix the entire problem at one go.  I hope to get back to bug 19963 this week.

Comment 9

[Tooru Fujisawa [:arai]]

Fixed as a part of bug 382721.