379351 - [BeOS] Thebes building broken in gfxRunCache

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Doug Shelton]

Attachment: bustage console output

Same issue as other locations in this code; gcc 2.95.3 is more strict than later gccs.  Attachment has console output of build failure.

Comment 1

[Doug Shelton]

Attachment: adds appropriate friend statements to allow build under BeOS

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 263402 [details] [diff] [review]
adds appropriate friend statements to allow build under BeOS

sorry, this needs review from an actual gfx peer

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 263402 [details] [diff] [review]
adds appropriate friend statements to allow build under BeOS

the code looks fine, but can you add a newline between the friend decl and the start of the actual struct, and maybe put a comment that this is only needed for older compilers?

Comment 4

[Doug Shelton]

Attachment: added formatting and comment as requested

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 263504 [details] [diff] [review]
added formatting and comment as requested

Going through old reviews -- sorry!  (This code doesn't exist any more, so clearing)

Comment 6

[JP Rosevear [:jpr]]

Closing, as per #5.