380345 - Remove dummy connection/statement from the History database

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Brett Wilson]

I have discovered that sqlite now keeps the cache between transaction automatically, removing the need for this extra connection stuff that I added. I think you need to sync to a new sqlite for this to work.

It should be possible to delete the mDummyDBConn, mDBDummyStatement, StartDummyStatement(), StopDummyStatement().

According to Dr. Hipp, we should also use "PRAGMA locking_mode=EXCLUSIVE;". This will keep the file locked all the time. It will increase performance by truncating the journal instead of re-creating the file which should be faster. It will also be dramatically faster if some virus scanners are installed (apparently, they slow down creates much more than writes).

If we do this, we should add locking to the I/O layer for extra safety (bug 329960). This will prevent stupid people from opening the DB manually while we are using it and corrupting it. That bug was stalled because the old way of having multiple connections made locking complex. Now you should just be able to lock when it says.

Comment 1

[(not reading, please use [e-mail] instead)]

thanks for the bug report, brett.  do you know which version of sqlite we need for this (http://www.sqlite.org/changes.html), or do you recommend we move to the latest-and-greatest?

Comment 2

[Brett Wilson]

I don't know of any reason not to move to the latest.

Comment 3

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

removes the dummy connection code, adds the locking pragma. more info about the lock here:

http://www.sqlite.org/pragma.html#pragma_locking_mode

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 269303 [details] [diff] [review]
fix v1

r=sspitzer

Comment 5

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.135; previous revision: 1.134
done
Checking in toolkit/components/places/src/nsNavHistory.h;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.h,v  <--  nsNavHistory.h
new revision: 1.83; previous revision: 1.82
done

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv