380422 - The evaluating iframe may contain nuts (and other remainders)

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Simon Bünzli]

(From bug 238898 comment #24)
> Hrm, this doesn't behave properly with javascript: URLs that don't cause a new
> load, e.g. evaluating ("const a=1;", "a;", "a;") will result in ("", 1, error)
> when it should result in ("", error, error), but I guess that happens currently
> too because displayResult() is only called onload. This was mentioned in bug
> 158475 comment 4, so I guess it's known. Might be worth filing a bug on it
> anyways.

Inserting the following line just before setting the location to the new javascript: URL fixes this issue:

+  iframe.contentDocument.location = "about:blank"; // reset the iframe

I'll add a patch once bug 238898 has been fixed.

Comment 1

[Simon Bünzli]

Attachment: fix

Comment 2

[[e-mail]]

Comment on attachment 264505 [details] [diff] [review]
fix

I'm sure what I said on IRC was to use contentWindow, not contentDocument (nsDocument simply calls GetLocation on its nsIDOMWindowInternal). But as you're repeating yourself I now prefer var Evaluator = document.getElementById("Evaluator").contentWindow; etc. sr=me with that fixed.

Comment 3

[Simon Bünzli]

Attachment: using contentWindow

... but keeping |evaluator| lower-cased as all other variables are.

Comment 4

[Simon Bünzli]

This bitrots my patch to bug 369097. I'll update it after this one's been checked in.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> (From update of attachment 264505 [details] [diff] [review])
> I'm sure what I said on IRC was to use contentWindow, not contentDocument
> (nsDocument simply calls GetLocation on its nsIDOMWindowInternal).

Oops, that's right. Sorry about that.

Comment 6

[Nickolay_Ponomarev]

mozilla/toolkit/components/console/content/console.js         1.8
mozilla/xpfe/components/console/resources/content/console.js  1.27

Comment 7

[Wladimir Palant]

This caused bug 386501.