Closed
Bug 380703
Opened 17 years ago
Closed 17 years ago
separators in bookmark manager dialog and bookmark sidebar have a (16px x 16px) blank space
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha6
People
(Reporter: moco, Assigned: christineyen+bugs)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 3 obsolete files)
21.38 KB,
image/png
|
Details | |
747 bytes,
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
separators in bookmark manager dialog have a (16x16px) blank space see also bug #334669, where onemen.one fixed this for winstripe
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Updated•17 years ago
|
Assignee: nobody → cyen
Target Milestone: --- → Firefox 3 alpha6
Assignee | ||
Comment 2•17 years ago
|
||
Attachment #267438 -
Flags: review?
Assignee | ||
Comment 3•17 years ago
|
||
css tweak, doesn't change appearance on linux -- check windows?
Attachment #267439 -
Flags: review?(sspitzer)
Assignee | ||
Updated•17 years ago
|
Attachment #267438 -
Attachment is obsolete: true
Attachment #267438 -
Flags: review?
Reporter | ||
Comment 4•17 years ago
|
||
> css tweak, doesn't change appearance on linux -- check windows?
That patch would only affect mac, but I don't think it is the right fix.
Assignee | ||
Comment 5•17 years ago
|
||
I would argue that it should still be the same fix, just a different file. No other trees to my knowledge use separators, so this patch should only affect the relevant trees within Places.
Attachment #267439 -
Attachment is obsolete: true
Attachment #268124 -
Flags: review?(sspitzer)
Attachment #267439 -
Flags: review?(sspitzer)
Reporter | ||
Comment 6•17 years ago
|
||
Comment on attachment 268124 [details] [diff] [review] patch, in theright file clearing review, christine is working on a different patch
Attachment #268124 -
Flags: review?(sspitzer)
Assignee | ||
Comment 7•17 years ago
|
||
As Seth pointed out, the error was caused by the renaming of a tree-col from "Name" in places.xul to "title," and therefore the ineffectiveness of the existing "treechildren::-moz-tree-twisty(Name, separator) { -moz-appearance:none; }" in mozilla/toolkit/themes/pinstripe/global/tree.css...
Attachment #268124 -
Attachment is obsolete: true
Attachment #268158 -
Flags: review?(sspitzer)
Reporter | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox3?
Reporter | ||
Comment 8•17 years ago
|
||
Comment on attachment 268158 [details] [diff] [review] patch #3, just kidding about the other two r=sspitzer
Attachment #268158 -
Flags: review?(sspitzer) → review+
Reporter | ||
Updated•17 years ago
|
Summary: separators in bookmark manager dialog have a (16x16px) blank space → separators in bookmark manager dialog and bookmark sidebar have a (16px x 16px) blank space
Reporter | ||
Comment 9•17 years ago
|
||
fixed. Checking in places.css; /cvsroot/mozilla/browser/themes/pinstripe/browser/places/places.css,v <-- places.css new revision: 1.10; previous revision: 1.9 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•17 years ago
|
||
reminder to Christine to log spin off bugs: 1) the bug that "padding: 0px;" fixes is also a bug in Firefox 2 2) the potential removal or cleanup of the "Name" / separator rules in tree.css
Reporter | ||
Comment 11•17 years ago
|
||
> 1) the bug that "padding: 0px;" fixes is also a bug in Firefox 2 see bug #384236 > 2) the potential removal or cleanup of the "Name" / separator rules in tree.css no bug logged because Seamonkey bookmark/history UI uses "Name" tree-cols, and they are/will use toolkit, seamonkey will need those rules.
Depends on: 384236
Comment 12•17 years ago
|
||
(In reply to comment #11) >>2) the potential removal or cleanup of the "Name" / separator rules in tree.css >no bug logged because Seamonkey bookmark/history UI uses "Name" tree-cols, and >they are/will use toolkit, seamonkey will need those rules. Actually we already appear to use similar rules in our bookmarks.css: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/themes/classic/communicator/bookmarks/bookmarks.css&rev=1.42&mark=48-50,53-55,58-60,63-65,72-74,86-88,90-92,94-97,99-101#90
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Comment 13•17 years ago
|
||
verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre
Status: RESOLVED → VERIFIED
Comment 14•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•