381186 - Edit Form Info doesn't work in suiterunner builds

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Mark Banner (:standard8)]

Edit form info isn't working, and we'd like to keep this working even if we only use wallet for nightly builds (i.e. its dropped by the time we do a release). Opening the edit form info page gives:

Error: uncaught exception: Permission denied to get property ChromeWindow.initPanel

Neil has a patch for this...

Comment 1

[[e-mail]]

Attachment: Proposed patch

The basic issue is that the individual pages are loaded from chrome://wallet/locale/ so localizers can change the available fields.
However these pages no longer have full chrome privileges. Therefore I
* Moved the load handler from each separate page to a central load handler
* Passed a parameter to the load handler so that Urlspecific can access it
* Also fixed a cross-document element creation bug
(you can only append nodes to the document you use to create them).

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 265289 [details] [diff] [review]
Proposed patch

I don't think this patch is working right.

With the patch I get to view the data that was set up previously (via migration), and I can change fields that have values already set.

If I try and set values in blank fields, when I click OK, nothing happens and the following error is shown on the console:

JavaScript error: chrome://communicator-region/locale/wallet/WalletName.xul, line 1: Append is not defined
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Node cannot be used in a document other than the one in which it was created"  code: "4" nsresult: "0x80530004 (NS_ERROR_DOM_WRONG_DOCUMENT_ERR)"  location: "chrome://communicator/content/wallet/WalletViewer.js Line: 358"]
************************************************************

Also when I go onto some panes, like the "Primary Contact Information"-> "Address", and drop down the arrow at the end I get the following errors:

JavaScript error: chrome://communicator-region/locale/wallet/WalletAddress.xul, line 1: Append is not defined
JavaScript error: , line 0: uncaught exception: [Exception... "Security error"  code: "1000" nsresult: "0x805303e8 (NS_ERROR_DOM_SECURITY_ERR)"  location: "chrome://global/content/bindings/menulist.xml Line: 533"]

Comment 3

[[e-mail]]

Attachment: Fixed patch

* Additionally fixes the additional misuse of docment.createElementNS

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 265379 [details] [diff] [review]
Fixed patch

This seems to work ok now. I still get the:

JavaScript error: , line 0: uncaught exception: [Exception... "Security error" 
code: "1000" nsresult: "0x805303e8 (NS_ERROR_DOM_SECURITY_ERR)"  location:
"chrome://global/content/bindings/menulist.xml Line: 533"]

errors, but if your happy that's not a problem (or exists in branch), I'm willing to go with it on the basis that we hope to dump wallet soon anyway.

Comment 5

[[e-mail]]

That's actually a variant of bug 329394, so it's a separate bug.

Comment 6

[[e-mail]]

Fix checked in.