381203 - Anonymous setter functions!?

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> s = setter function () { print("blah") }  
setter function () {
    print("blah");
}

Comment 1

[Jesse Ruderman]

I think "setter function" should only be allowed as a declaration, not as an expression, to avoid bugs like:

js> f = (function() { (setter function f() { }).x }) 
function () {
    setter function f() {}.x;
}
js> eval("" + f)
typein:8: SyntaxError: syntax error:
typein:8:     setter function f() {}.x;
typein:8: ..........................^

And it should require there to be an identifier being set:

js> setter function () { print("blah") }  
setter function () {
    print("blah");
}

Comment 2

[Jesse Ruderman]

But if they're only allowed as declarations, we'll have to do something about uneval spitting them out as expressions and/or disallow __lookupGetter__ from returning them:

js> getter function p() { print(4) }
js> uneval({x: this.__lookupGetter__("p")})
({x:getter function p() {print(4);}})
js> uneval([this.__lookupGetter__("p")])
[getter function p() {print(4);}]

Comment 3

[Jesse Ruderman]

I think I heard rumblings of removing this feature(?) recently.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

js> s = setter function () { print("blah") }
typein:11: SyntaxError: missing ; before statement:
typein:11: s = setter function () { print("blah") }
typein:11: ...........^

Comment 5

[Jeff Walden [:Waldo]]

Bug 517580 removed this syntax.