381247 - Speed up mkdepend on Windows + VMWare

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

I build on Windows under VMWare, with the sources in VMWare's shared file system and local objdirs. I noticed that mkdepend was running incredibly slowly. For example, mkdepend on nsPresShell.cpp:
real    0m32.250s
user    0m0.031s
sys     0m0.031s

Primitive profiling suggests that it was spending most of its time blocked on stat() calls searching include directories for include files. On a hunch I replaced the stat() calls to check for file existence with a call to GetFileAttributesEx. The result:
real    0m1.578s
user    0m0.015s
sys     0m0.015s

I suspect the issue is that stat() fills in a lot of fields like inode and user/group/other permissions that are expensive to gather on Windows, especially in VMWare's file system perhaps.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 2

[Alfred Peng]

Attachment: Bustage?

The patch breaks the tinderbox build on Solaris: http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox-Ports. S_ISDIR should be the POSIX macro for this check.

Comment 3

[Alfred Peng]

Checking in include.c;
/cvsroot/mozilla/config/mkdepend/include.c,v  <--  include.c
new revision: 3.6; previous revision: 3.5
done

Comment 5

[Ryan VanderMeulen [:RyanVM]]

roc, any chance this could get landed on the 1.8.1 branch as well?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Dunno. Nominate it and find out

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 265348 [details] [diff] [review]
fix

approved for 1.8.1.5, a=dveditz for release-drivers

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 265348 [details] [diff] [review]
fix

closing tree early, this will have to wait for next time

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 265348 [details] [diff] [review]
fix

approved for 1.8.1.7, a=dveditz for release-drivers