381352 - remove CSS rules pointing to inexistent classicBindings.xml

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Robert Kaiser]

formatting.css on *stripe and Classic refers to classicBindings.xml but that file doesn't even exist. We seems to not use the "double-box" that appears to be defined using that file anyways, so we just should remove those definitions.

See http://mxr.mozilla.org/mozilla/search?string=classicBindings.xml and http://mxr.mozilla.org/seamonkey/search?string=double-box

Comment 1

[Stefan [:stefanh]]

Attachment: Remove obsolete style rules (only toolkit/themes part of patch checked in)

Heh, that stuff is pretty old - it doesn't even exist on the 1.7 branch. Not sure if it's worth changing Classic (it's already behind on mac), but I've included Classic in the patch (hence the sr request).

Comment 2

[Robert Kaiser]

Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

That's exactly the patch I would have done, so marking review as Neil still gets his word on sr ;-)

Comment 3

[Stefan [:stefanh]]

Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

I think I need toolkit review as well :-)

Comment 4

[Asaf Romano (gone)]

Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

r=mano.

Comment 5

[Stefan [:stefanh]]

Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

Cancelling the sr request. I'll just checkin the *stripe part.

Comment 6

[Stefan [:stefanh]]

--> toolkit

Comment 7

[Stefan [:stefanh]]

Checking in toolkit/themes/pinstripe/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/formatting.css,v  <--  formatting.css
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/themes/winstripe/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/formatting.css,v  <--  formatting.css
new revision: 1.9; previous revision: 1.8
done

Comment 8

[[e-mail]]

Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

This got delayed while I was catching up on bugmail but for the record you would have had r+sr=me.