381434 - Open "livemark name" ignores middle click

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Pablo Greco]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre

When middle clicking the menuitem Open "livemark name", menu is dismissed and firefox does nothing. Ctrl+Left click works as expected opening a new tab.

Reproducible: Always

Steps to Reproduce:
1.Open any livemark
2.Middle Click on Open "livemark name"
Actual Results:  
Nothing happens

Expected Results:  
Livemark url should open in a new tab

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed that it doesn't open in a new tab.

Comment 2

[Phil Ringnalda (:philor)]

Back to Places - RSS D&P just handles the feed, it doesn't create a bookmark menu and click handlers from it.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Thanks for the explanation. I always wondered; it seemed inconsequent.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

related to bug 328686?

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: intercept middle-click with onclick

the middle-click is usually served in BT_onClick, but we need to call the onCommand handler of the item as target.onCommand(event). this is not possible due to Bug 246720, so this can be addressed using checkForMiddleClick in the onClick attribute of the element.

Notice that now middle-clicking this item will open all feed items in tabs, that is clearly not the expected behaviour, the user wants really to open the feed url in a new tab, while he ends up with a dialog asking if he really wants to open N tabs...

Comment 9

[Asaf Romano (gone)]

Comment on attachment 293249 [details] [diff] [review]
intercept middle-click with onclick

> // If a user middle-click this

middle-clicks.

r=mano.

Comment 10

[Reed Loden [:reed]]

Checking in browser/base/content/browser-places.js;
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.76; previous revision: 1.75
done

Comment 11

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre)
Gecko/2007121805 Minefield/3.0b3pre 

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv