381485 - [Mac] Rename "Get Info" back to "Properties"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jesse Ruderman]

The Places landing changed the menu item "Properties" to "Get Info" on Mac.

I use it for renaming bookmarks (on the bookmarks toolbar) much more often than I use it for anything else, so having it named "Get Info" is strange.  "Get Info" makes sense for files in Finder, where most of the controls are read-only and the modifiable controls are rarely used, but it doesn't make sense for bookmarks.

Comment 1

[Joey Minta]

Attachment: patch

The mac ifdef has been there since rev. 1.1, so I'm not sure of the original motivation behind it.  That said, here's a patch to makes all platforms use "Properties."

Comment 2

[Asaf Romano (gone)]

Comment on attachment 265546 [details] [diff] [review]
patch

This breaks the organizer window.

Comment 3

[Joey Minta]

Attachment: patch v2

Better patch this time.  Gets all the uses of the entities.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 265584 [details] [diff] [review]
patch v2

r=mano.

Comment 5

[Joey Minta]

Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.74; previous revision: 1.73
done
Checking in browser/components/places/content/placesOverlay.xul;
/cvsroot/mozilla/browser/components/places/content/placesOverlay.xul,v  <--  placesOverlay.xul
new revision: 1.11; previous revision: 1.10
done
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--  places.dtd
new revision: 1.23; previous revision: 1.22
done

Comment 6

[John P Baker]

> -<!ENTITY cmd.show_infoWin.accesskey
> +<!ENTITY cmd.properties.accesskey
>    "i">

"P" ???

Comment 7

[Joey Minta]

P is used for "Paste" already
http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/browser/places/places.dtd#91

Comment 8

[John P Baker]

(In reply to comment #6)
> > -<!ENTITY cmd.show_infoWin.accesskey
> > +<!ENTITY cmd.properties.accesskey
> >    "i">
> 
> "P" ???

Sorry for bugspam - that is Paste. On Firefox 2 "r".

Comment 9

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv