381538 - "clean up" button remains greyed out after download completes

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[aja+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre

Also found the following message in the error console.

Error: Ci is not defined
Source file: chrome://mozapps/content/downloads/downloads.js
Line: 485

Reproducible: Always

Steps to Reproduce:
1. Download a file
2. Once it's done, notice "clean up" button still greyed out
3.
Actual Results:  
"clean up" button greyed out after download completes

Expected Results:  
"clean up" button should not remain greyed out when download is complete

This was my first download since the download manager change was checked in.

Comment 1

[aja+bugzilla]

Oops...missed another perhaps more relevant message in the error console:


Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]
Source file: chrome://mozapps/content/downloads/downloads.js
Line: 547

Comment 2

[-fullmetaljacket-]

i can actually reproduce this.

"clean up" remains disabled because the downloaded item does not had the focus.

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
> [nsIObserverService.removeObserver]
> Source file: chrome://mozapps/content/downloads/downloads.js
> Line: 547

Naw, that's just because of the first one - the observer never got registered.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Basically, we were updating the database a bit too late.  I'll make a test case for this bug tomorrow.

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

Includes test changes to actually test for this bug.

Comment 6

[Shawn Wilsher :sdwilsh]

Comment on attachment 265684 [details] [diff] [review]
v1.1

There are still a few minor issues here, I don't want to have you review this yet.

Comment 7

[Shawn Wilsher :sdwilsh]

Attachment: v1.2

This also includes some stuff from Bug 381646 (just the test file).  I had to refactor things a bit to actually do this right.

Comment 8

[Shawn Wilsher :sdwilsh]

Attachment: v1.3

Addresses comments from irc.

Comment 9

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.h;
new revision: 1.24; previous revision: 1.23
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.78; previous revision: 1.77
Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.57; previous revision: 1.56
Checking in toolkit/components/downloads/test/unit/test_download_manager.js;
new revision: 1.8; previous revision: 1.7

Comment 10

[aja+bugzilla]

WFM now.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070523 Minefield/3.0a5pre ID:2007052316 [cairo]

Comment 11

[L.I.A.R.]

Exactly the same behaviour in FF 19.0!!!!

Download DialogBox always shows "clear list" button as greyed out in FF 19.0

Comment 12

[L.I.A.R.]

Attachment: Screenshot of identical error in FF19 (10 years later)!!!

Comment 13

[Marco Bonardo [:mak]]

(In reply to L.I.A.R. from comment #12)
> Created attachment 718953 [details]
> Screenshot of identical error in FF19 (10 years later)!!!

10 years later, is maybe cause that's another bug?
please go to bug 842871.