382037 - Default CC is ignored when creating a bug via the webservice

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Nahor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: 

When creating a new bug using the webservice, if there is no "cc" parameter when calling "Bug.create", the emails in the default CC of the product/component is ignored, i.e. the new bug will not have any emails in its CC list.

However, when a "cc" parameter is passed, even if it's an empty array, then the default CC is used, i.e. there will be emails in the  new bug's CC list.

Reproducible: Always

Comment 1

[Max Kanat-Alexander]

Yes, this is an error in _check_cc in Bugzilla::Bug.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

I'm pretty sure this will fix it, though I can't test it because XMLRPC.sh isn't working right, for some reason.

Comment 3

[Nahor]

>-    return [] unless $ccs;
>+    return [map {$_->id} $component->initial_cc] unless $ccs;

I don't really know Perl so it may be a stupid idea but what about:
  $ccs = [] unless $ccs;
instead of returning early from the function?

This should make the function less likely to break again because of a new feature like the default CC list.

Comment 4

[Frédéric Buclin]

Comment on attachment 266113 [details] [diff] [review]
v1

>+    return [map {$_->id} $component->initial_cc] unless $ccs;

You must write: @{$component->initial_cc} as $component->initial_cc is an arrayref. Your fix is working fine with @{} added. Please fix that on checkin. r=LpSolit

Comment 5

[Max Kanat-Alexander]

tip:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.180; previous revision: 1.179
done

3.0:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.171.2.1; previous revision: 1.171
done