382141 - fxexp-win32-tbox should upload symbols for breakpad

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I'm testing Textframe-enabled builds and I've run into a website which crashes pretty much 100% with it. However, due to the fact that symbols aren't uploaded for the experimental builds, the submitted breakpad reports don't do anything to help diagnose the crash.

Having the experimental tinderbox upload symbols would make testing experimental builds much more useful.

Comment 1

[(not currently active) Ted Mielczarek]

The only thing that could be bad here is if they have the same build hour, so the same build id, since we store the list of symbols per build in a text file ala firefox-3.0a5pre-Linux-0000000000-symbols.txt, so builds with the same build id would overwrite each other.  The only thing that would actually screw up would be symbol cleanup, though.  I'll let preed make the call on this.

Comment 2

[Benjamin Smedberg]

I don't think we should do this unless we can name the .txt file uniquely... e.g. call it firefox-3.0a5pre-Linux-2007052503-textframe-symbols.txt

Comment 3

[(not currently active) Ted Mielczarek]

This should be pretty easy, just copy the tinder-config bits from fx-win32-tbox, and set the env var MOZ_SYMBOLS_EXTRA_BUILDID=textframe or something similar.  We also need to make sure that the ffxbld key is present on the box.

Comment 4

[Chris Cooper [:coop] (he/him)]

Heh, I actually asked preed about this when he created the initial config.

I will check-in the necessary changes and make sure we have at least 3 hours difference in the nightly build hour for TextFrame vs trunk.

Comment 5

[Chris Cooper [:coop] (he/him)]

Config has been updated on the feature_textframe branch:

Checking in tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/win32/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.10.2.3; previous revision: 1.10.2.2
done

Comment 6

[(not currently active) Ted Mielczarek]

Thanks coop.  It's not necessary to offset the build hour with the EXTRA_BUILDID env var set, since that will prevent collisions, but it won't hurt anything.

Comment 7

[Chris Cooper [:coop] (he/him)]

Mac is uploading symbols now too.