382223 - Add support for Camellia to PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement)

Description

[okazaki]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.3) Gecko/20070523 Firefox/2.0.0.3
Build Identifier: 

add support for Camellia(RFC4132) when NSS 3.12 is for firefox-trunk.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[okazaki]

Attachment: patch for security/manager/ssl/src/nsNSSComponent.cpp

Comment 2

[okazaki]

Attachment: patch for netwek/base/public/security-prefs.js

Comment 3

[Steffen Wilberg]

Please request review on both patches from [e-mail], once you're ready to do so.

Comment 4

[okazaki]

Please review both patches since NSS 3.12 alpha1 is into fx 3.0.

Comment 5

[Gen Kanai [:gen]]

Hi Kai- could I ask you to please review this patch before the next alpha release (or beta?)- thank you very much.

Comment 6

[okazaki]

It seems 3.12 is back out for firefox-trunk,
please review 3.12 is import again.

Comment 7

[Kai Engert (:KaiE:)]

The patch builds OK.

I would like to try connecting to a site that implements Camellia.

Is there a public server I could connect to for testing?

Comment 8

[rui]

Thank you for checking camellia patch.
Camellia HP server supports Camellia.
http://info.isl.ntt.co.jp/crypt/eng/camellia/index.html

Comment 9

[Kai Engert (:KaiE:)]

(In reply to comment #8)
> Thank you for checking camellia patch.
> Camellia HP server supports Camellia.
> http://info.isl.ntt.co.jp/crypt/eng/camellia/index.html

Thank you for this link.

I used your address with https: https://info.isl.ntt.co.jp/crypt/eng/camellia/index.html

When I use a Mozilla that uses the NSS 3.12 and the patch from this bug, when I connect to that address, page info says  "Camellia-256 256 bit"

Looks good to me.

Comment 10

[Kai Engert (:KaiE:)]

Comment on attachment 266361 [details] [diff] [review]
patch for netwek/base/public/security-prefs.js

r=kengert

Comment 11

[Kai Engert (:KaiE:)]

Comment on attachment 266360 [details] [diff] [review]
patch for security/manager/ssl/src/nsNSSComponent.cpp

r=kengert

Comment 12

[Kai Engert (:KaiE:)]

Checked in