382460 - [client] When building XUL versions of SeaMonkey use -register not regxpcom

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix.

We've recently switched SeaMonkey to be an xul app on trunk (use toolkit) - its still xpfe on branches.

We've discovered that the tinderboxes are still calling regxpcom and not ./seamonkey -register when doing the initial setup, we suspect this may have caused a Ts regression, but in either case it is wrong to call regxpcom on an xul app and we need to fix it.

This patch adds SeaMonkey to the appropriate if statement in the same way as other places in that script - note that xpfe builds have a blank vendor name which is why it works.

I'd like to get it in soon so we can see if this does fix Ts or not.

Comment 1

[Robert Kaiser]

Comment on attachment 266626 [details] [diff] [review]
The fix.

$profile_product_name does not work there (as perl -c even states), you need to use $Settings::ProductName directly there.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix v2

Correction based on Robert's comment, I actually decided binary name woud be best to use here.

Comment 3

[Mark Banner (:standard8)]

I've just checked this in. Hopefully tinderboxes will pick it up soon.

Comment 4

[Mark Banner (:standard8)]

Patch checked in, Linux has picked this up ok. Fixed.