Closed Bug 382849 Opened 17 years ago Closed 17 years ago

Wrong gzip comment process in HTTP Compress converter

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta2

People

(Reporter: soflare, Assigned: soflare)

Details

Attachments

(1 file)

fix
1.05 KB, patch
bzbarsky
: review+
Biesinger
: superreview+
sayrer
: approval1.9+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4 XPCOMViewer/0.9.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4

I think it must be a typo. In file netwerk/streamconv/converters/nsHTTPCompressConv.cpp

 case GZIP_COMMENT:
     if (mFlags & GZIP_COMMENT)
     {

It should be:

 case GZIP_COMMENT:
     if (mFlags & COMMENT)
     {


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Version: unspecified → Trunk
Attached patch fix — — Splinter Review 
Add a fix.
Attachment #287508 - Flags: review?(bzbarsky)
Assignee: nobody → solar
Comment on attachment 287508 [details] [diff] [review]
fix

Yeah, makes sense.  biesi, can you look too?
Attachment #287508 - Flags: superreview?(cbiesinger)
Attachment #287508 - Flags: review?(bzbarsky)
Attachment #287508 - Flags: review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #287508 - Flags: superreview?(cbiesinger) → superreview+
Attachment #287508 - Flags: approval1.9?
Attachment #287508 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Thanks for the patch!

Checking in netwerk/streamconv/converters/nsHTTPCompressConv.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp,v  <--  nsHTTPCompressConv.cpp
new revision: 1.28; previous revision: 1.27
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: