383169 - Tinderbox: only call 'make deliver' on Windows

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris Cooper [:coop] (he/him)]

This has been an error _forever_. 

This target only exists on Windows, so we should use the existing platform determination code to make sure it only gets run on win32.

Patch forthcoming.

Comment 1

[Benjamin Smedberg]

Yuck. Why don't we just make "deliver" a no-op on non-Windows platforms?

Comment 2

[(not currently active) Ted Mielczarek]

You could just put an else right here:
http://mxr.mozilla.org/mozilla/source/Makefile.in#203

and put in an empty deliver target.

Comment 3

[Chris Cooper [:coop] (he/him)]

Adding the code to tinderbox means I only have to do it in one place, rather than on every branch. It will go away when Talkback is retired anyway.

Comment 4

[Chris Cooper [:coop] (he/him)]

Attachment: Only call 'make deliver' target on Windows

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 267173 [details] [diff] [review]
Only call 'make deliver' target on Windows

r=cf, looks good.

Comment 6

[Chris Cooper [:coop] (he/him)]

Checking in post-mozilla-rel.pl;
/cvsroot/mozilla/tools/tinderbox/post-mozilla-rel.pl,v  <--  post-mozilla-rel.pl
new revision: 1.119; previous revision: 1.118
done