Closed Bug 383174 Opened 17 years ago Closed 17 years ago

Add new reportMatch function in shell.js

Categories

(Rhino Graveyard :: Core, defect)

Product:
Rhino Graveyard
Component:
Core
Version:
1.6R6
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: norrisboyd, Assigned: norrisboyd)

Details

Attachments

(1 file)

Patch for reportMatch
8.64 KB, patch
bc
: review+
Details | Diff | Splinter Review 
I've added a new analog to reportCompare that instead takes an expected regular expression to match the expected value to. This helps Rhino since a number of the tests are written to expect exact matches on error messages. The patch also contains changes to several tests to use reportMatch for these types of cases.

    
    

    
  
Comment on attachment 267195 [details] [diff] [review]
Patch for reportMatch

works for me, but drop the rhino-n.tests stuff. That has moved anyway right?

        Attachment #267195 -
        Flags: review+

    
    

    
  
Yes, thanks, the rhino-n.tests diff was not intended for this bug.

Do you want me to check in?

    
    

    
  
Committed patch (excepting changes to rhino-n.tests).
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
  
Version: 1.6R5 → 1.6R6

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: