Closed
Bug 384123
Opened 17 years ago
Closed 9 years ago
Return value nonsense in nsIComponentRegistrar comments
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
DUPLICATE
of bug 331566
People
(Reporter: jwkbugzilla, Assigned: jwkbugzilla)
Details
Attachments
(1 file)
|
3.92 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Several void methods in nsIComponentRegistrar are documented as:
@return NS_OK Unregistration was successful.
NS_ERROR* Method failure.
That's nonsense, these methods don't return anything, and this documentation of error conditions applies to all XPCOM methods equally. So this should simply be removed.
Attachment #268064 -
Flags: superreview?(darin.moz)
Attachment #268064 -
Flags: review?(darin.moz)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 268064 [details] [diff] [review] Proposed patch trev if you're still interested, this is bitrotten but at least part is still valid and you're welcome to push it ;-)
Attachment #268064 -
Flags: superreview?(darin.moz)
Attachment #268064 -
Flags: superreview?
Attachment #268064 -
Flags: review?(darin.moz)
Attachment #268064 -
Flags: review+
|
|
||
Updated•11 years ago
|
Attachment #268064 -
Flags: superreview?
|
Assignee | |
Comment 2•9 years ago
|
||
This has been resolved in bug 331566 it seems.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•