384130 - MacLaunchHelper LaunchChildMac doesn't propagate environment to child

Status: RESOLVED WONTFIX

(Toolkit Graveyard :: XULRunner, defect)

Description

[James Turner]

LaunchChildMac is used when re-launching the application (eg due to an updated version being installed, or the component registry being rebuilt).  At present it doesn't copy the environment variables of the parent (original) process through to the child, which caused some surprises while testing / developing.

Patch against MacLaunchHelper.m to follow shortly.

Comment 1

[James Turner]

Attachment: Proposed fix, copy the environment from NSProcessInfo

Comment 2

[Josh Aas]

Comment on attachment 268071 [details] [diff] [review]
Proposed fix, copy the environment from NSProcessInfo

looks fine to me but I want mento to review this as well

Comment 3

[Mark Mentovai]

Comment on attachment 268071 [details] [diff] [review]
Proposed fix, copy the environment from NSProcessInfo

Huh.  I thought that the environment was already carried through correctly.  For example, MOZ_LAUNCHED_CHILD, which we set in the parent process during XRE restart, is properly picked up in the child process.  James, what specific behavior are you experiencing/what variables are you finding not being set according to your expectations?

Comment 4

[Mark Mentovai]

James, do you have any responses to comment 3?

Comment 5

[James Turner]

The specific env var was DYLD_LIBRARY_PATH, which makes me wonder if it's treated specially. However, other changes have made this fix less important, so perhaps it should simple be dropped.

Comment 6

[Mark Mentovai]

Well, we're getting most of the environment carried through - if the system is purposely preventing a few variables from making it, it's probably got a reason, and I don't want to override that unless it fixes something that we're definitely doing wrong.  Are you saying that DYLD_LIBRARY_PATH is now carried through properly, or that something else changed and you no longer need DYLD_LIBRARY_PATH?

Comment 7

[James Turner]

(Sorry for the delay) - something else changed and we no longer need DYLD_LIBRARY_PATH. Shall I resolve this as WONTFIX? (Not sure if I have permissions for that)