384239 - "Search in Bookmarks" search field looks much worse on mac than it does on windows

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

"Search in Bookmarks" search field looks much worse on mac than it does on windows

For example, it is is much taller.

screen shot coming.

I'm wondering if it should look more like the search box in the browser, where the drop down is centered vertically?

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot on mac

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: how it looks on windows

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: a suggestion of where to put the drop down, if we plan on keeping it (center it vertically)

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

This entire window is due for a pretty major redesign (a thread will start soon in dev.apps.firefox), so we may want to hold off on tweaking the current interface.

Comment 5

[(not reading, please use [e-mail] instead)]

re-assign to faaborg so that no one takes this an implements it before we have a redesign.

Comment 6

[José Jeria]

Isn't there suppose to be an icon next to the arrow? Like Thunderbird's search field. 

Comment 8

[Dietrich Ayala (:dietrich)]

http://people.mozilla.com/~faaborg/files/granParadisoUI/placesOrganizer_i5WindowLayout.png

per the mockup, we can remove the folder filter drop-arrow altogether.

Comment 9

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

this just removes the filter popup altogether for now. we might hook that functionality back up later via different UI, so i've left the plumbing intact.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 277158 [details] [diff] [review]
fix v1

what about onPlaceSelected() and other code in places.js?  

If we remove this from places.xul, lots of stuff will break.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

To put the removal of the folder filter drop down into context: the plan is to display a scope bar control when the user performs a search:

http://people.mozilla.com/~faaborg/files/granParadisoUI/placesSearch_i4AdvancedSearch.png

(note that this mockup isn't final)

We will still need to know what folder the user was in, because that will be one of the options in the scope bar.

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 277158 [details] [diff] [review]
fix v1

r=sspitzer, dietrich explained over irc.

do we have a spin off bug to track faaborg's "scope bar"?

Comment 13

[Dietrich Ayala (:dietrich)]

(In reply to comment #12)
> (From update of attachment 277158 [details] [diff] [review])
> r=sspitzer, dietrich explained over irc.
> 
> do we have a spin off bug to track faaborg's "scope bar"?
> 

no, that mockup isn't final yet. the search builder is currently bug 387744.

Comment 14

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.77; previous revision: 1.76
done

Comment 15

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv