384642 - remove __callee__ from Call objects, or fix its prototype leak hazard

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

Summary says it all. In light of JS2/ES4 with its stack inspection stuff we would rather do away with __callee__, but it might be used enough that we'll keep it, at least until Mozilla 2. Anyone with knowledge of uses in our tree or addons, please pipe up.

/be

Comment 1

[Brendan Eich [:brendan]]

See http://developer.mozilla.org/es4/proposals/stack_inspection.html for the ES4 stack reflection proposal.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

__callee__ was silly, it did not work unless the function containing it was heavyweight (scoped by a call object), so it could end up binding to some outer function call's callee. This patch removes it. Igor likes removal of code, so I hope to get fast r+ ;-).

/be

Comment 3

[Igor Bukanov]

Comment on attachment 268728 [details] [diff] [review]
fix

I indeed like the patches mostly with minuses.

Comment 4

[Brendan Eich [:brendan]]

Fixed on trunk:

js/src/jsfun.c 3.189

/be