384671 - when resetting the history sidebar view, don't use applyFilter()

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

when resetting the history sidebar view by the "View" button, don't use applyFilter().

When you use applyFilter with no search terms, the query uri for the nsNavHistoryQueryResultNode is different.

specifically, it doesn't contain "beginTime=-2592000000000&beginTimeRef=1&endTime=7200000000&endTimeRef=2", which is part of our history query.

this wasn't a problem, except for bug #380735 we build up a urn using the node's uri.

so these are not the same rdf resource:

urn:places-persist:beginTime=-2592000000000&beginTimeRef=1&endTime=7200000000&endTimeRef=2&group=0&sort=1&type=1,-1,mail.mozilla.com

urn:places-persist:place:group=0&sort=1&type=1,-1,mail.mozilla.com

This is needed by bug #380735.

hmm, maybe we can fix this (and improve history performance) by *not* specifying the beginTime and endTime at all, for either the history side bar or the history menu, because we really want all visits, and we're paying an overhead by checking the time!

I still think we should avoid calling applyFilter() with no search string, but I'll test the other side of this fix as well, which is to drop the time part of our history queries.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch

this patch both fixes the issue of not calling applyFilter() without a search value (instead, calling initPlace(), which is just the same code that we call when the history sidebar loads)

but also, we stop doing time searches (for both history sidebar and history menu) which should be a performance win.

once I finish testing, I'll seek a review.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch

just fix history-panel.js here, needed bug #380735, and will spin off the other fix as a performance bug.

Comment 3

[(not reading, please use [e-mail] instead)]

> will spin off the other fix as a performance bug.

see bug #384677

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 268597 [details] [diff] [review]
patch

correct patch coming

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

previous patch would not call applyFilter() after the initial call to searchHistory(), so if you typed "goo" we'd search, but add "gle" to get "google" we would not call applyFilter().  doh.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: updated, per mano, call load() directly

Comment 7

[Asaf Romano (gone)]

Comment on attachment 268884 [details] [diff] [review]
updated, per mano, call load() directly

r=mano.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: move and clean up the comment

Comment 9

[(not reading, please use [e-mail] instead)]

fixed.

cvs ci browser/components/places/content/history-panel.js
Checking in browser/components/places/content/history-panel.js;
/cvsroot/mozilla/browser/components/places/content/history-panel.js,v  <--  hist
ory-panel.js
new revision: 1.18; previous revision: 1.17
done

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Does this really need to block, Seth? Is there a major chance of it regressing due to other work?

Comment 11

[(not reading, please use [e-mail] instead)]

> Does this really need to block, Seth?

No, so clearing the request.

> Is there a major chance of it regressing due to other work?

No, I don't think this would regress due to other changes.

Comment 12

[Al Billings [:abillings - ex-MoCo]]

Can someone verify this change or tell us how to do so in order to mark this as verified and get it off everyone's plate?

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv